structuredconfig for train.py and eval.py #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
May 3, 2024
milocress
force-pushed
the
milo/foundry-type-cleanup
branch
from
baff2e3
to
eccf849
Compare
dakinggg
approved these changes
May 8, 2024
There was a problem hiding this comment.
LGTM, but please coordinate with @ShashankMosaicML to minimize the difficulty of his PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
popstatements with omegaconf.structuredconfig initializationllm-foundry-regression-tests-runner-mtlkuRllm-foundry-regression-tests-runner-FXx9Gbllm-foundry-regression-tests-runner-ZShXQpUnit tests with variables:
tests/data/test_dataloader.py::test_correct_paddingtests/a_scripts/eval/test_eval.py::test_loader_evaltest/a_scripts/train/test_train.py::test_train_gauntletManual tests with variables (latest):
mpt-125m-chinchilla-regression-bN2HOrmpt-125m-chinchilla-J1XkBimpt-125m-chinchilla-regression-kSFIMk