Make mpt7b finetuning more obvious #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
May 10, 2023
|
Note: #90 is merged |
alextrott16
approved these changes
May 12, 2023
There was a problem hiding this comment.
A couple minor suggestions to correct some issues with model configs but otherwise looks great!
BTW t5-small_dolly_sft.yaml also has the device instead of init_device issue, but I couldn't suggest a change on it because it was just a rename. Please apply the same fix there.
alextrott16
reviewed
May 12, 2023
dakinggg
approved these changes
May 12, 2023
zhranj
reviewed
May 12, 2023
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
* make mpt7b finetuning more obvious * change yaml structure and references to paths * needed to intall pre-commit * fix merge issue * Local dataset rework * Apply suggestions from code review * YAML touch ups --------- Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com> Co-authored-by: Alex Trott <alex@mosaicml.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RESEARCH-710
Also change the folder structure of the YAMLs to make it more clear which MPTs are pretrained from the HF Hub and which are an architecture for pretraining.
WARNING: This will not work until #90 is merged!