Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moto[s3] requirement from <5,>=4.0.1 to >=4.0.1,<6 #3516

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 5, 2024

Updates the requirements on moto[s3] to permit the latest version.

Changelog

Sourced from moto[s3]'s changelog.

5.0.12

Docker Digest for 5.0.12: sha256:e1bde8f908f2fdf0878c8e4398561badd016b51b4d9fd8dcb9f4daef936a4427

General:
    * The MotoProxy can now be run on Windows

New Services: * DirectConnect: * create_connection() * delete_connection() * describe_connections() * update_connection()

* DynamoDB:
    * describe_export()
    * export_table_to_point_in_time()
    * list_export()
  • NetworkManager:

    • create_device()
    • create_link()
    • create_link()
    • delete_device()
    • delete_link()
    • delete_site()
    • get_devices()
    • get_links()
    • get_sites()
    • list_tags_for_resource()
  • SageMaker:

    • list_endpoints()
    • list_endpoint_configs()
    • create_auto_ml_job_v2()
    • describe_auto_ml_job_v2()
    • list_auto_ml_jobs()
    • stop_auto_ml_job()
    • create_compilation_job()
    • describe_compilation_job()
    • list_compilation_jobs()
    • delete_compilation_job()
    • create_domain()
    • describe_domain()
    • list_domains()
    • delete_domain()
    • create_model_explainability_job_definition()
    • describe_model_explainability_job_definition()
    • list_model_explainability_job_definitions()
    • delete_model_explainability_job_definition()

... (truncated)

Commits
  • 707b272 Pre-Release: Up Version Number
  • 434c7a1 Prep release 5.0.12 (#7929)
  • 0f25f2f CloudFormation: update_stack() - Improve UsePreviousValue behaviour (#7928)
  • 2ca9df6 CognitoIDP: ID-token is different when username=email (#7927)
  • fbec8b6 CognitoIDP: initiate_auth with USERNAME_PASSWORD_AUTH and SMS/Software Token ...
  • 743044f ACM: DomainValidationOptions should have SUCCESS-status (#7926)
  • 7cd2763 Consolidate Neptune and RDS backends (#7925)
  • 210a2a3 Feature: Sagemaker Model Quality Job Definition (#7916)
  • ec76952 chore: update SSM default AMI's (#7912)
  • ac09274 Feature: Sagemaker Hyper Parameter Tuning Job (#7917)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [moto[s3]](https://github.com/getmoto/moto) to permit the latest version.
- [Release notes](https://github.com/getmoto/moto/releases)
- [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md)
- [Commits](getmoto/moto@4.0.1...5.0.12)

---
updated-dependencies:
- dependency-name: moto[s3]
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner August 5, 2024 01:00
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 5, 2024
@mvpatel2000 mvpatel2000 closed this Aug 5, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 5, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/moto-s3--gte-4.0.1-and-lt-6 branch August 5, 2024 16:32
@mvpatel2000 mvpatel2000 restored the dependabot/pip/moto-s3--gte-4.0.1-and-lt-6 branch August 5, 2024 16:32
@mvpatel2000
Copy link
Contributor

@bigning triaging to you given you're most familiar here

@mvpatel2000 mvpatel2000 reopened this Aug 5, 2024
@bigning
Copy link
Contributor

bigning commented Aug 9, 2024

i searched the code base, the moto is only used here in the unit test

.
Since moto5.0, they changed the API from mock_s3 -> mock_aws. So i made change in setup.py to require >=5.0.1

Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since tests passes.

@bigning bigning merged commit 88caae9 into main Aug 9, 2024
14 checks passed
@bigning bigning deleted the dependabot/pip/moto-s3--gte-4.0.1-and-lt-6 branch August 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants