Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ghcr and update build matrix generator #3465

Merged
merged 31 commits into from
Aug 21, 2024
Merged

add ghcr and update build matrix generator #3465

merged 31 commits into from
Aug 21, 2024

Conversation

KevDevSha
Copy link
Member

@KevDevSha KevDevSha commented Jul 9, 2024 •
edited
Loading

What does this PR do?

  • Implement GHCR build in matrix and dev/release build action and commit ghcr images from readme as these are private images.
  • Fix generate build matrix error:
Traceback (most recent call last):
  File "/Users/kevin.deshawn/Projects/composer/docker/generate_build_matrix.py", line 329, in <module>
    _main()
  File "/Users/kevin.deshawn/Projects/composer/docker/generate_build_matrix.py", line 301, in _main
    _write_table('PYTORCH_BUILD_MATRIX', table_contents)
  File "/Users/kevin.deshawn/Projects/composer/docker/generate_build_matrix.py", line 165, in _write_table
    post = contents.split(end_table_tag)[1]
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

@KevDevSha KevDevSha requested a review from a team as a code owner July 9, 2024 22:07
@KevDevSha KevDevSha closed this Jul 9, 2024
@KevDevSha KevDevSha reopened this Jul 30, 2024
@KevDevSha KevDevSha requested a review from dakinggg July 30, 2024 22:20
@KevDevSha KevDevSha enabled auto-merge (squash) August 2, 2024 18:00
mvpatel2000
mvpatel2000 reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run this and test it?

@KevDevSha
Copy link
Member Author

@mvpatel2000 build test passed https://github.com/mosaicml/composer/actions/runs/10377163660

mvpatel2000
mvpatel2000 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

docker/generate_build_matrix.py Outdated Show resolved Hide resolved
@KevDevSha @mvpatel2000
Update docker/generate_build_matrix.py
9cd25e2 
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
@mvpatel2000 mvpatel2000 merged commit dec879e into main Aug 21, 2024
26 checks passed
@mvpatel2000 mvpatel2000 deleted the kevin/ghcr-build branch August 21, 2024 18:53
@snarayan21 snarayan21 mentioned this pull request Aug 26, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevDevSha @mvpatel2000