Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip HSDP + TP pytests that require torch 2.3 or above #3426

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Skip HSDP + TP pytests that require torch 2.3 or above #3426

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
13ecba9
test
Jun 25, 2024
f5fe4a9
skip if torch version less than 2.3
Jun 25, 2024
8fd3fa4
Merge branch 'dev' into 4gpu-connect-test
KuuCi Jun 25, 2024
b959ffd
typo in ema
Jun 25, 2024
c27f1e6
Merge branch '4gpu-connect-test' of github.com-regular:mosaicml/compo…
Jun 25, 2024
e3106bf
add remote
Jun 25, 2024
d841cfb
comments
Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/trainer/test_fsdp_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ def test_fsdp_full_state_dict_load(
):
if use_hsdp:
pytest.xfail('Known Pytorch issue with HSDP, waiting for pytorch patch')
if (use_tp or use_hsdp) and version.parse(torch.__version__) < version.parse('2.3.0'):
pytest.skip('HSDP and TP require torch 2.3.0 or later')
if autoresume:
run_name = 'my-cool-autoresume-run'
else:
Expand Down Expand Up @@ -833,8 +835,8 @@ def test_fsdp_partitioned_state_dict_load(
):
if weights_only and autoresume:
pytest.skip('Weights only with autoresume is not supported')
if use_tp and version.parse(torch.__version__) < version.parse('2.3.0'):
pytest.skip('TP requires torch 2.3.0 or later')
if (use_tp or use_hsdp) and version.parse(torch.__version__) < version.parse('2.3.0'):
pytest.skip('HSDP and TP require torch 2.3.0 or later')

load_ignore_keys = [] if load_ignore_keys is None else load_ignore_keys

Expand Down
Loading