Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip HSDP + TP pytests that require torch 2.3 or above #3426

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Skip HSDP + TP pytests that require torch 2.3 or above #3426

merged 7 commits into from
Jun 25, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Jun 25, 2024

What does this PR do?

Some pytests require torch >= 2.3.0 but were not properly skipping. This pr simply checks the torch version to determine if the test should run

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@KuuCi KuuCi marked this pull request as ready for review June 25, 2024 19:36
@KuuCi KuuCi requested a review from mvpatel2000 June 25, 2024 19:36
mvpatel2000
mvpatel2000 reviewed Jun 25, 2024
View reviewed changes
tests/trainer/test_fsdp_checkpoint.py Outdated Show resolved Hide resolved
tests/trainer/test_fsdp_checkpoint.py Outdated Show resolved Hide resolved
@KuuCi KuuCi requested a review from mvpatel2000 June 25, 2024 20:18
@KuuCi KuuCi merged commit b27a6aa into dev Jun 25, 2024
17 checks passed
@KuuCi KuuCi deleted the 4gpu-connect-test branch June 25, 2024 20:42
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@KuuCi @mvpatel2000
Skip HSDP + TP pytests that require torch 2.3 or above (mosaicml#3426)
217ecc8 
* test

* skip if torch version less than 2.3

* typo in ema

* add remote

* comments

---------

Co-authored-by: v-chen_data <v-chen_data@example.com>
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
@KuuCi @mvpatel2000
Skip HSDP + TP pytests that require torch 2.3 or above (#3426)
a7218d1 
* test

* skip if torch version less than 2.3

* typo in ema

* add remote

* comments

---------

Co-authored-by: v-chen_data <v-chen_data@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuuCi @mvpatel2000