Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter for epoch in iteration #3407

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add setter for epoch in iteration #3407

merged 1 commit into from
Jun 18, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Jun 17, 2024

What does this PR do?

This allows the user to set the epoch in the iteration. This is needed for PPO to signal to early break out of an iteration by setting the epoch to the max number of epochs in an iteration.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested a review from mvpatel2000 June 17, 2024 20:46
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test

composer/core/time.py Show resolved Hide resolved
composer/core/time.py Show resolved Hide resolved
tests/test_time.py Show resolved Hide resolved
@b-chu b-chu merged commit 9dda1e2 into dev Jun 18, 2024
17 checks passed
@b-chu b-chu deleted the ppo-callback branch June 18, 2024 17:29
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants