Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffering time to mlflow logger #3401

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Add buffering time to mlflow logger #3401

merged 3 commits into from
Jun 14, 2024

Conversation

chenmoneygithub
Copy link
Contributor

@chenmoneygithub chenmoneygithub commented Jun 14, 2024 •
edited
Loading

What does this PR do?

Add buffering time to mlflow logger, tested with unit test along with manual testing.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@chenmoneygithub chenmoneygithub requested a review from a team as a code owner June 14, 2024 01:13
@chenmoneygithub chenmoneygithub marked this pull request as draft June 14, 2024 01:13
@chenmoneygithub chenmoneygithub marked this pull request as ready for review June 14, 2024 02:58
mvpatel2000
mvpatel2000 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

tests/loggers/test_mlflow_logger.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: does this actually need to be configurable? or should you just pick a good default value?

@mvpatel2000
Copy link
Contributor

qq: does this actually need to be configurable? or should you just pick a good default value?

Hm yea @chenmoneygithub can we set a default at least to something you'd like? maybe 5s?

@chenmoneygithub
Copy link
Contributor Author

I am putting 10s for now.

@chenmoneygithub chenmoneygithub merged commit 0e45b71 into mosaicml:dev Jun 14, 2024
17 checks passed
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@chenmoneygithub @mvpatel2000
Add buffering time to mlflow logger (mosaicml#3401)
436380c 
* Add buffering time to mlflow logger

* rename

* change default and fix comments
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
@chenmoneygithub @mvpatel2000
Add buffering time to mlflow logger (#3401)
a1c581d 
* Add buffering time to mlflow logger

* rename

* change default and fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg left review comments

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenmoneygithub @mvpatel2000 @dakinggg