Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for 'CUDA error: out of memory' when auto-microbatching #3400

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Check for 'CUDA error: out of memory' when auto-microbatching #3400

merged 1 commit into from
Jun 13, 2024

Conversation

JAEarly
Copy link
Contributor

@JAEarly JAEarly commented Jun 13, 2024

See #3397.

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@JAEarly JAEarly mentioned this pull request Jun 13, 2024
Closed
@JAEarly JAEarly force-pushed the jearly/auto-microbatching-cuda-oom branch from a74bb8e to 7055213 Compare June 13, 2024 10:20
mvpatel2000
mvpatel2000 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :)

@mvpatel2000 mvpatel2000 merged commit aedb229 into mosaicml:dev Jun 13, 2024
17 checks passed
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@JAEarly @mvpatel2000
Check for 'CUDA error: out of memory' with auto-microbatching (mosaic…
f7dccaf 
…ml#3400)
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
@JAEarly @mvpatel2000
Check for 'CUDA error: out of memory' with auto-microbatching (#3400)
b07b82e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAEarly @mvpatel2000