Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only requires databricks-sdk when inside the Databricks platform #3389

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

antoinebrl
Copy link
Contributor

What does this PR do?

We would like to use MLFlow outside of the databricks platform. For such scenario, the package databricks-sdk don't have to be installed. With this contribution the import of the databricks.sdk is gated by the presence of the DATABRICKS_TOKEN environment variable, making it possible to reduce the dependency chain.

@antoinebrl antoinebrl requested a review from a team as a code owner June 9, 2024 11:42
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvpatel2000 mvpatel2000 merged commit 7c46d8a into mosaicml:dev Jun 9, 2024
17 checks passed
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants