-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding checkpoint backwards compatibility tests after 0.23.0 release #3377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run dailies and make sure they pass before merging this? And it would be helpful to link the daily test run in a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agree with Saaketh, can we fire off dailies to verify?
@mvpatel2000 , @snarayan21 sounds good. I will fire Daily test after the CI issues are resolved. |
The daily test indeed failed |
@bigning yes, that's correct. we don't need to ensure that torch 2.1 and 2.2 users can load torch 2.3 checkpoints, only that torch 2.3 users can load old checkpoints for backwards compat. |
What does this PR do?
Following the release processing doc, this is the last step to add checkpoint backward compatibility tests
Daily test: https://github.com/mosaicml/composer/actions/runs/9407180074