Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch 2.3.1 Upgrade #3367

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Torch 2.3.1 Upgrade #3367

merged 8 commits into from
Jun 6, 2024

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Jun 5, 2024 •
edited
Loading

What does this PR do?

Bumps to torch 2.3.1. Removes monkeypatches which have been upstreamed.

Regressions pass: composer-regression-tests-runner-b2N9SB

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner June 5, 2024 20:54
@mvpatel2000 mvpatel2000 requested a review from dakinggg June 5, 2024 20:54
@mvpatel2000 mvpatel2000 merged commit 5bf4d60 into dev Jun 6, 2024
17 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/torch-231 branch June 6, 2024 14:27
@eracah
Copy link
Contributor

eracah commented Jun 6, 2024 •
edited
Loading

This breaks gpu tests. _verify_options is only defined if torch < 2.3.1, but we monkeypatch _verify_options for 2.3.1
https://github.com/mosaicml/composer/actions/runs/9405411167/job/25906501355?pr=3361

mvpatel2000 added a commit that referenced this pull request Jul 22, 2024
@mvpatel2000 @snarayan21
Torch 2.3.1 Upgrade (#3367)
8df9a27 
* Revert "Autoresume Validation with Max Duration (#3358)"

This reverts commit f0eae8a.

* add bump

* bump deepspeed

* revert deepspeed bump

* add state dict

---------

Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvpatel2000 @eracah @dakinggg @snarayan21