Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Type Hints for PEP 585 #3344

Merged
merged 10 commits into from
May 30, 2024
Merged

Migrate Type Hints for PEP 585 #3344

merged 10 commits into from
May 30, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Update type hints following PEP 585.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mvpatel2000 mvpatel2000 marked this pull request as ready for review May 30, 2024 17:54
@mvpatel2000 mvpatel2000 requested review from a team as code owners May 30, 2024 17:54
@mvpatel2000 mvpatel2000 requested a review from b-chu May 30, 2024 17:54
b-chu
b-chu approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

snarayan21
snarayan21 reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some capitalization stuff, other than that lgtm

get those lines up fr

composer/loggers/in_memory_logger.py Outdated Show resolved Hide resolved
composer/utils/batch_helpers.py Outdated Show resolved Hide resolved
tests/loggers/test_cometml_logger.py Outdated Show resolved Hide resolved
karan6181
karan6181 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank You!

@mvpatel2000 mvpatel2000 merged commit dfbaf14 into mosaicml:dev May 30, 2024
15 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/lower-type branch May 30, 2024 19:02
@snarayan21 snarayan21 mentioned this pull request Aug 14, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 left review comments

@karan6181 karan6181 karan6181 approved these changes

@b-chu b-chu b-chu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvpatel2000 @karan6181 @b-chu @snarayan21