Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional CheckpointSaver instantiation inside the Trainer #3334

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

antoinebrl
Copy link
Contributor

What does this PR do?

By making the instantiation of the CheckpointSaver optional inside the Trainer, the user can provide a (custom) callback used for saving, loading and resumption.

What issue(s) does this change relate to?

@antoinebrl antoinebrl force-pushed the ab/checkpoint-saver-callback branch from 0aa59e5 to fb8652b Compare May 27, 2024 13:58
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @eracah can you please review as well?

@mvpatel2000 mvpatel2000 requested a review from eracah May 28, 2024 14:40
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIscussed with @eracah lgtm

@mvpatel2000 mvpatel2000 merged commit 1e1c04d into mosaicml:dev Jun 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional CheckpointSaver instantiation inside the Trainer
2 participants