Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert TP integration #3328

Merged
merged 2 commits into from
May 25, 2024
Merged

Revert TP integration #3328

merged 2 commits into from
May 25, 2024

Conversation

dakinggg
Copy link
Contributor

Seeing some test failures. Reverting while we sort those out.

@dakinggg dakinggg marked this pull request as ready for review May 25, 2024 02:44
@dakinggg dakinggg requested a review from snarayan21 May 25, 2024 02:45
snarayan21
snarayan21 approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dakinggg dakinggg merged commit f154ea6 into mosaicml:dev May 25, 2024
15 checks passed
mvpatel2000 added a commit that referenced this pull request May 28, 2024
@mvpatel2000
Revert "Revert TP integration (#3328)"
01f7988 
This reverts commit f154ea6.
mvpatel2000 added a commit that referenced this pull request May 30, 2024
@mvpatel2000
Tensor Parallelism v2 (#3335)
c9a51d4 
* Revert "Revert TP integration (#3328)"

This reverts commit f154ea6.

* fix device mesh

* fix backcompat

* lint

* fix

* elif

* fix test

* fix error

* lit

* filter warnings

* add filter

* link issue

* lint

* make version

---------

Co-authored-by: Your Name <you@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@snarayan21 snarayan21 snarayan21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @mvpatel2000 @snarayan21