-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FSDP ckpt by filtering User Waring #3327
Conversation
This reverts commit 24f088c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j316chuck Can you run the daily tests on this branch and see if they pass now? will approve after that
Hm automerge was on so it merged even though its not fixed on linked dailies... |
sad...but the error isn't related to this PR, it seems related to the TP PR @mvpatel2000 |
@mvpatel2000 I think it fixed the UserWarning but now we are hitting a new failure.
Let's fix in a new PR! |
What does this PR do?
Fix FSDP ckpt by filtering User Warning
What issue(s) does this change relate to?
Fix failing dailies
https://github.com/mosaicml/composer/actions/runs/9231304954