Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkpoint events to mosaicml logger #3316

Merged
merged 1 commit into from
May 24, 2024
Merged

Add checkpoint events to mosaicml logger #3316

merged 1 commit into from
May 24, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented May 23, 2024

What does this PR do?

Adds metadata logging to mosaicml logger for when checkpoint upload starts when a checkpoint is done loading. The information logged is the timestamp and the training duration of the checkpoint.

Tested in events-test-8ReCjx

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested a review from a team as a code owner May 23, 2024 11:21
@b-chu b-chu changed the title Add checkpoint events to mosaicml logger [WIP] Add checkpoint events to mosaicml logger May 23, 2024
@b-chu b-chu requested review from waiwuc and jjanezhang May 23, 2024 11:30
@b-chu b-chu changed the title [WIP] Add checkpoint events to mosaicml logger Add checkpoint events to mosaicml logger May 23, 2024
@b-chu b-chu requested a review from bigning May 23, 2024 11:30
composer/loggers/mosaicml_logger.py Outdated Show resolved Hide resolved
composer/loggers/mosaicml_logger.py Outdated Show resolved Hide resolved
composer/callbacks/checkpoint_saver.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding based on discussions

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you include a manual test to verify this works since I don't htink we can easily unit test this?

Edit: maybe its mockable for testing?

composer/loggers/remote_uploader_downloader.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to force flush!

@b-chu b-chu enabled auto-merge (squash) May 24, 2024 21:58
@b-chu b-chu merged commit 6640fc6 into dev May 24, 2024
15 checks passed
@b-chu b-chu deleted the events branch May 24, 2024 22:36
@b-chu b-chu mentioned this pull request Jul 10, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants