Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overwrite on upload retry in remote uploader downloader #3310

Merged
merged 6 commits into from
May 20, 2024
Merged

Allow overwrite on upload retry in remote uploader downloader #3310

merged 6 commits into from
May 20, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented May 20, 2024 •
edited
Loading

What does this PR do?

Allows overwrite on upload retries.

If an upload fails and results in a partial upload, we should allow overwriting.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@irenedea irenedea changed the title Rud retry Allow overwrite on upload retry in remote uploader downloader May 20, 2024
@irenedea irenedea marked this pull request as ready for review May 20, 2024 17:07
@irenedea irenedea requested a review from a team as a code owner May 20, 2024 17:07
@irenedea irenedea requested review from bigning and dakinggg May 20, 2024 17:08
@bigning
Copy link
Contributor

bigning commented May 20, 2024

It looks reasonable to me, but will let @dakinggg signoff

mvpatel2000
mvpatel2000 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

snarayan21
snarayan21 reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will also wait on others

snarayan21
snarayan21 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will also wait on others

@irenedea irenedea enabled auto-merge (squash) May 20, 2024 17:52
@irenedea irenedea merged commit 552958c into mosaicml:dev May 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@snarayan21 snarayan21 snarayan21 approved these changes

@bigning bigning Awaiting requested review from bigning

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irenedea @bigning @mvpatel2000 @snarayan21