Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update platform references #3304

Merged
merged 3 commits into from
May 20, 2024
Merged

Update platform references #3304

merged 3 commits into from
May 20, 2024

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented May 18, 2024 •
edited
Loading

What does this PR do?

Updates outdated doc links & naming

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aspfohl
aspfohl commented May 18, 2024
View reviewed changes
docs/source/index.rst Outdated Show resolved Hide resolved
@aspfohl aspfohl marked this pull request as ready for review May 20, 2024 16:04
@aspfohl aspfohl requested review from a team as code owners May 20, 2024 16:04
mvpatel2000
mvpatel2000 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR descriptions are your friend, even if its just a docs change!

@aspfohl aspfohl merged commit 57c7b72 into dev May 20, 2024
15 checks passed
@aspfohl aspfohl deleted the anna/mcli branch May 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@veronicapglasgow veronicapglasgow Awaiting requested review from veronicapglasgow

@bandish-shah bandish-shah Awaiting requested review from bandish-shah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspfohl @mvpatel2000