Skip compression check with symlink files #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
requested review from
eracah,
j316chuck,
snarayan21,
dakinggg and
bigning
dakinggg
approved these changes
May 17, 2024
eracah
reviewed
May 17, 2024
I agree it's not ideal... maybe it should be an explicit whitelist of compressors. This wouldn't raise an error if you try a compressor that doesn't exist, but it would increase robustness. I'm inclined to leave it as is and if it breaks again we can change? |
Ok lemme add a JIRA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip compression check with symlink files. Add unit tests.
Fixes an issue where some previous checkpoints where
.pt.symlink