Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace load_fsdp_monolith_ with load_monolith_ #3288

Merged
merged 6 commits into from
May 15, 2024

Conversation

milocress
Copy link
Contributor

@milocress milocress commented May 15, 2024

What does this PR do?

Replace load_fsdp_monolith_ with load_monolith_

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@milocress milocress changed the title replace load_monolith_ with load_fsdp_monolith_ replace load_fsdp_monolith_ with load_monolith_ May 15, 2024
mvpatel2000
mvpatel2000 previously approved these changes May 15, 2024
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is technically BC breaking, but we dont think anyone is using this attribute on state -- it is primarily used internally in Composer. It will avoid making easy mistakes by having two variables with the same name and fixes tests.

@mvpatel2000 mvpatel2000 dismissed their stale review May 15, 2024 17:19

We can preserve the old attribute on state and fwd it with a deprecation warning

composer/core/state.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milocress milocress enabled auto-merge (squash) May 15, 2024 17:53
@milocress milocress merged commit 423706b into mosaicml:dev May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants