Add option to stagger uploads based on local rank #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
changed the title
irenedea
approved these changes
May 10, 2024
irenedea
reviewed
May 10, 2024
dakinggg
commented
May 10, 2024
dakinggg
commented
May 10, 2024
eracah
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding a stagger based on local rank to the upload workers (i.e. the upload worker will wait by local rank * stagger). We are only exposing this via environment variable, as this is not something most users should be setting themselves.
Manual test:
stagger-upload-test-2-IggDEG(note that each ranks file was uploaded 1 minute apart)