Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily GCS tests #3268

Merged
merged 3 commits into from
May 8, 2024
Merged

Fix daily GCS tests #3268

merged 3 commits into from
May 8, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Fix daily GCS tests. Changes order in which monkeypatches are applied for test to mirror new format in GS object store

Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems calm, one question for personal clarity

@snarayan21
Copy link
Contributor

@mvpatel2000 run dailies to check if the PR works?

@mvpatel2000
Copy link
Contributor Author

@mvpatel2000 mvpatel2000 merged commit 6e4078c into dev May 8, 2024
29 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-daily-fcs branch May 8, 2024 20:23
j316chuck pushed a commit that referenced this pull request May 16, 2024
* fix test

* fix error

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants