Fix backwards compatibility tests, raise error for torch version mismatch #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
May 3, 2024
dakinggg
reviewed
May 3, 2024
|
daily tests are passing too |
b-chu
reviewed
May 6, 2024
| 'newer version of torch. Upgrade your torch version to load this checkpoint.', | ||
| ) | ||
| else: | ||
| raise |
There was a problem hiding this comment.
Uhh this is a bug right? You need to have raise e?
There was a problem hiding this comment.
you can also do raise like this to reraise the error
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
…atch (#3252) * fix daily tests, backwards compat * raise only on particular error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes FSDP checkpoint backwards compatibility tests, and raises a helpful error for likely torch version mismatch on checkpoint load. For context, the test that was failing was when trying to load a checkpoint written with torch 2.3.0 when using torch < 2.3.0, since the older torch versions could not correctly read the new metadata file.
What issue(s) does this change relate to?
Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)