Add offset and length arguments for checkpoint validation functions #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
May 2, 2024
irenedea
force-pushed
the
checkpoint-validation
branch
from
33db8c0
to
0591d33
Compare
irenedea
force-pushed
the
checkpoint-validation
branch
from
8c564e8
to
0e94dbb
Compare
dakinggg
approved these changes
May 2, 2024
mvpatel2000
approved these changes
May 3, 2024
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables passing a list of offset and lengths to checkpoint validation functions. This enables validation functions to closely mimic the behavior of torch sharded checkpoint loading.
Manual Test
checkpoint-validation-finetuning-load-all-ybefFB (loads weights and optimizer state)
checkpoint-validation-finetuning-CztzA5 (loads weights only)
checkpoint-validation-finetuning-autoresume-Lmr4Kd (autoresume)