add retry to gcs.upload_file #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Apr 30, 2024
@mvpatel2000 , waiting for customer's test and feedback |
|
Get feedback from customer, this fixed the checkpoint uploading issue. cc @mvpatel2000 |
mvpatel2000
approved these changes
May 6, 2024
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* add retry to gcs.upload_file * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
One of our client has the GCS upload error. The default DEFAULT_RETRY_IF_GENERATION_SPECIFIED only works if generation is specified which is not the case in our code. So we change to
DEFAULT_RETRYto enable the retryRelated issues: googleapis/python-storage#1231
configure retries: https://cloud.google.com/python/docs/reference/storage/latest/retry_timeout
what's generation number: https://medium.com/codebrace/using-object-versioning-for-google-cloud-storage-5577769d2c83