Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rename_metrics to Mlflow logger #3225

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Add rename_metrics to Mlflow logger #3225

merged 12 commits into from
Apr 30, 2024

Conversation

hanlint
Copy link
Contributor

@hanlint hanlint commented Apr 29, 2024

What does this PR do?

This PR allows users to rename metrics in MLflow by providing a dict mapping. This requires an exact match.

logger = MlflowLogger(
    rename_metrics={'loss/train': 'loss'}
)

Additionally, this PR also refactors several tests in test_mlflow_loggers to be more modular and parameterized.

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@hanlint hanlint requested a review from a team as a code owner April 29, 2024 23:11
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvpatel2000 mvpatel2000 merged commit 2289f5e into dev Apr 30, 2024
15 checks passed
@mvpatel2000 mvpatel2000 deleted the hanlin/rename_metrics branch April 30, 2024 17:04
j316chuck pushed a commit that referenced this pull request May 16, 2024
* add rename_metrics

* refactor tests, add rename_metrics test

* fix code quality

* update

* test

* debug: swap test order

* debug: minimize test

* rename test

---------

Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants