Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flash-attn 2.5.8 with no build isolation in docker images #3224

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

Uses the latest flash attention version and installs with no build isolation (as they recommend) in docker images, rather than building from source.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested a review from a team as a code owner April 29, 2024 19:01
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot of launching image and importing flash attn with no error before approval 🙏

@snarayan21
Copy link
Contributor Author

snarayan21 commented Apr 29, 2024

I don't think the failing GPU tests are relevant, seeing them on other PRs too. All images built successfully -- here's a screenshot of successful import with the torch 2.3.0 image:
Screenshot 2024-04-29 at 12 57 37 PM

And the flash-attn version is 2.5.8:
Screenshot 2024-04-29 at 1 01 00 PM

@snarayan21 snarayan21 enabled auto-merge (squash) April 29, 2024 23:43
@snarayan21 snarayan21 merged commit f0d9093 into dev Apr 30, 2024
27 checks passed
@snarayan21 snarayan21 deleted the saaketh/fa2_install branch April 30, 2024 00:07
j316chuck pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants