Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch 2.3 GPU tests #3218

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Fix torch 2.3 GPU tests #3218

merged 13 commits into from
Apr 29, 2024

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Apr 27, 2024 •
edited
Loading

What does this PR do?

Fix torch 2.3 GPU tests

  • Removes NO_SHARD in some tests (deprecated)
  • Monkeypatches lazy init into set model state
  • Fixes optim load

dakinggg
dakinggg reviewed Apr 29, 2024
View reviewed changes
composer/utils/checkpoint.py Show resolved Hide resolved
composer/core/state.py Outdated Show resolved Hide resolved
composer/core/state.py Outdated Show resolved Hide resolved
dakinggg
dakinggg approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg dakinggg merged commit 9da9d81 into dev Apr 29, 2024
15 checks passed
@dakinggg dakinggg deleted the mvpatel2000/fix-23-gpu branch April 29, 2024 23:34
j316chuck pushed a commit that referenced this pull request May 16, 2024
@mvpatel2000
Fix torch 2.3 GPU tests (#3218)
08c1fd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg