Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for proper run_name and not state name #3215

Merged
merged 38 commits into from
Apr 30, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Apr 26, 2024

Make sure getting existing runs pulls from os.environ as well as state run name

@KuuCi KuuCi requested a review from a team as a code owner April 26, 2024 00:03
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add PR descriptions! They are your friend

Please wait for #3208 to merge first

While ur at it, can u get the mosaicml logger to log the mlflow URL plz

@KuuCi
Copy link
Contributor Author

KuuCi commented Apr 29, 2024

test-mlflow-logger-EP7BFB

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@dakinggg dakinggg merged commit 6877abd into dev Apr 30, 2024
15 checks passed
@dakinggg dakinggg deleted the mlflow-logger-resumption-path branch April 30, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants