Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new Mlflow run by default and introduce run_group #3208

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Create new Mlflow run by default and introduce run_group #3208

merged 11 commits into from
Apr 30, 2024

Conversation

chenmoneygithub
Copy link
Contributor

@chenmoneygithub chenmoneygithub commented Apr 24, 2024 •
edited
Loading

What does this PR do?

Create new Mlflow run by default and introduce run_group. Currently the default behavior is to resume the Mlflow run by searching for existing run with the same name. As we discussed we should make the default behavior start a new run. Additionally to mirror the group in wandb, we are introducing the run_group tag.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@chenmoneygithub chenmoneygithub requested a review from a team as a code owner April 24, 2024 08:59
@chenmoneygithub chenmoneygithub marked this pull request as draft April 24, 2024 08:59
mvpatel2000
mvpatel2000 reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like your local linter may be applying a whole bunch of changes -- can we remove these? diff should be much smaller I think

composer/loggers/mlflow_logger.py Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
@chenmoneygithub chenmoneygithub force-pushed the mlflow-resumption branch 2 times, most recently from 0f24bd4 to f291aaf Compare April 25, 2024 04:14
@chenmoneygithub chenmoneygithub marked this pull request as ready for review April 25, 2024 05:41
mvpatel2000
mvpatel2000 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A minor nit for more helpful logs

composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Show resolved Hide resolved
@mvpatel2000 mvpatel2000 mentioned this pull request Apr 26, 2024
Merged
mvpatel2000
mvpatel2000 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more nits

composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
KuuCi
KuuCi approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@KuuCi KuuCi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvpatel2000 lgtm

@mvpatel2000 mvpatel2000 merged commit 230f24a into mosaicml:dev Apr 30, 2024
15 checks passed
j316chuck pushed a commit that referenced this pull request May 16, 2024
@chenmoneygithub @mvpatel2000
@dakinggg @snarayan21
Create new Mlflow run by default and introduce run_group (#3208)
7356414 
* clean up

* fix lint and test

* style

* lint

* fix lint

---------

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Co-authored-by: Saaketh Narayan <saaketh@mosaicml.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@KuuCi KuuCi KuuCi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenmoneygithub @mvpatel2000 @KuuCi @dakinggg @snarayan21