Enabling the computation of validation loss and other metrics when using sequence parallelism #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashankMosaicML
changed the title
mvpatel2000
approved these changes
Apr 9, 2024
staghado
pushed a commit
to lightonai/composer
that referenced
this pull request
Apr 13, 2024
…ing sequence parallelism (mosaicml#3183) * fix a bug in eval with seq parallelism * print debug values * .. * .. * .. * potentially fixing the eval bug * minor * minor * minor * .. * fixing is_sampler_distributed * removing redundant condition
staghado
pushed a commit
to lightonai/composer
that referenced
this pull request
Apr 13, 2024
…ing sequence parallelism (mosaicml#3183) * fix a bug in eval with seq parallelism * print debug values * .. * .. * .. * potentially fixing the eval bug * minor * minor * minor * .. * fixing is_sampler_distributed * removing redundant condition
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
…ing sequence parallelism (#3183) * fix a bug in eval with seq parallelism * print debug values * .. * .. * .. * potentially fixing the eval bug * minor * minor * minor * .. * fixing is_sampler_distributed * removing redundant condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
is_sampler_distributed = dataloader.sampler and ...tois_sampler_distributed = (dataloader.sampler is not None) and ...