Copy extra_init_params to get rid of recursive config dicts
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanlint
reviewed
Feb 1, 2022
A-Jacobson
pushed a commit
that referenced
this pull request
Feb 10, 2022
* Copy extra_init_params to get rid of recursive config dicts * remove empty lines Co-authored-by: hanlint <hanlin@mosaicml.com>
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
…ml#316) * Copy extra_init_params to get rid of recursive config dicts * remove empty lines Co-authored-by: hanlint <hanlin@mosaicml.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #236, if you specify the
extra_init_paramsdict as part of theconfigfor the run, you would get a recursive dictionary by inserting theconfigdict into it directly. Added a copy to prevent that.