Compressor fixes #3142
Merged
Compressor fixes #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of lzma provided by the lzma package has a bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700681 where it refuses to decompress if the file extension does not match, causing the test to fail. This could be worked around but the `xz-utils` package already provides a version of `lzma` that does not have this issue, so that can be used instead.
|
I think the reason for the test failure is that the docker image being used isn't updated until the PR is merged? I can implement the workaround into the test (use the proper file extension for the test file) and that should fix it |
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* add notes on running tests in docker * improve error handling of CliCompressor * remove problematic lzma package from docker image The version of lzma provided by the lzma package has a bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700681 where it refuses to decompress if the file extension does not match, causing the test to fail. This could be worked around but the `xz-utils` package already provides a version of `lzma` that does not have this issue, so that can be used instead. * run as current user in docker container * use compressor extension for test file * improved documentation and error messages of CliCompressor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the issue encountered here #3118 (comment) where
lzmais refusing to decompress a file in the docker container.The version of lzma provided by the lzma package has a bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700681
where it refuses to decompress if the file extension does not match, causing the test to fail. This could be worked around but the
xz-utilspackage already provides a version oflzmathat does not have this issue, so that can be used instead.Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)