Composer object store download retry #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-chu
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Some failing tests but overall looks good. Let's clean up the unused import and pyright ignores. This would retry with every exception though, not just the ones that aren't retried from the object store. So you would 5x the number of retries that were already happening.
@b-chu , for the retries that already happening, if the oci internal retry works, then we don't do extra retry. Only if the internal retry fails, we do extra retry (i think that's kind of what we want. :) ). btw, the test error is unrelated, it's fixed in this PR #3142 |
mvpatel2000
reviewed
Mar 22, 2024
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* retry * up * up * up * fix * up * a * up * up * up * up * lint * up * up * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add object_store checkpoint downloading retry
test
bigning-debug-cp-loading-2-J6z0wB ConnectionError
in the logging, there is one rank succeeded at 2nd attempt.
another run: bigning-debug-cp-loading-2-9Lq8am ChunkedEncodingError
