Fixing sequence parallel error conditions and adding type float for microbatch_size in typehints #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashankMosaicML
changed the title
ShashankMosaicML
changed the title
mvpatel2000
approved these changes
Mar 22, 2024
ShashankMosaicML
deleted the
shashank/allow_num_samples_to_reflect_padding_fraction
branch
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
…icrobatch_size in typehints (#3139) * fixing the current error condition * fixing error condition * temporarily adding debug info * temporarily adding debug info * fixing divide by 0 error * fixing a bug * fixing a bug * reverting changes from prev commits * Update state.py * Update state.py * Update trainer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes sequence parallel error conditions and adds type float for microbatch_size in typehints