Adding log exception to Mosaic Logger #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjanezhang
changed the title
|
Can we do some sort of manual test to see how the exception looks when it's logged to mcloud? |
mvpatel2000
reviewed
Mar 8, 2024
eracah
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
whoa that manual test example is pretty cool. I like that it shows up really nicely in the describe run output. LGTM. Thanks, @jjanezhang !
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* adding failure reason log wrapper * added test and exception to json * removed non custom class vars from run metadata exc * force flush exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding log exception to Mosaic Logger
Adding function to log exceptions to run metadata
Being used in foundry to catch custom errors
Manually tested:
Related PR: mosaicml/llm-foundry#1014