Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s3_bucket pytest cli flag #3064

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove s3_bucket pytest cli flag #3064

merged 1 commit into from
Feb 27, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Feb 27, 2024

What does this PR do?

Removes the s3_bucket flag in pytest and adds it to the fixture. This makes the pytest cicd more generalizable.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu marked this pull request as ready for review February 27, 2024 20:25
@b-chu b-chu requested a review from a team as a code owner February 27, 2024 20:25
@b-chu b-chu merged commit 64bdd7d into dev Feb 27, 2024
13 of 14 checks passed
@b-chu b-chu deleted the fixture branch February 27, 2024 21:14
@b-chu b-chu restored the fixture branch February 27, 2024 21:15
@b-chu b-chu deleted the fixture branch February 27, 2024 21:15
j316chuck pushed a commit that referenced this pull request Mar 29, 2024
j316chuck pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants