Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff. Fix PLE & LOG lints #3050

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

Skylion007
Copy link
Contributor

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Add a PLE code for the PyLint Error Codes (Python code that is very likely to be wrong). I also updated ruff to the latest version and updated the config as well.

@Skylion007 Skylion007 requested review from a team as code owners February 22, 2024 21:48
@Skylion007 Skylion007 force-pushed the skylion007/fix-PLE-error-composer branch from d995abc to 26c15a8 Compare February 22, 2024 21:51
@Skylion007 Skylion007 changed the title Update ruff. Fix and enable PLE lints Update ruff. Fix PLE & LOG lints Feb 22, 2024
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

composer/profiler/utils.py Show resolved Hide resolved
@Skylion007 Skylion007 enabled auto-merge (squash) February 22, 2024 23:09
@Skylion007 Skylion007 merged commit 9ecea4f into dev Feb 22, 2024
14 checks passed
@Skylion007 Skylion007 deleted the skylion007/fix-PLE-error-composer branch February 22, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants