Use Mosaic constant for GPU file prefix #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j316chuck
reviewed
Feb 16, 2024
j316chuck
reviewed
Feb 16, 2024
j316chuck
approved these changes
Feb 16, 2024
dakinggg
reviewed
Feb 16, 2024
| @@ -485,7 +486,7 @@ def main(): | |||
| MOSAICML_PLATFORM_ENV_VAR, | |||
| 'false').lower() == 'true' and str(os.environ.get(MOSAICML_LOG_DIR_ENV_VAR, 'false')).lower() != 'false': | |||
| log.info('Logging all GPU ranks to Mosaic Platform.') | |||
| log_file_format = f'{os.environ.get(MOSAICML_LOG_DIR_ENV_VAR)}/gpu_{{rank}}.txt' | |||
| log_file_format = f'{os.environ.get(MOSAICML_LOG_DIR_ENV_VAR)}/{os.environ.get(MOSAICML_GPU_LOG_FILE_PREFIX_ENV_VAR)}{{local_rank}}.txt' | |||
There was a problem hiding this comment.
@jjanezhang this will error if the env var doesn't exist, did you want that? or should it be more permissive?
There was a problem hiding this comment.
That's a good point, let me add it to the condition so we don't fail the run entirely if the prefix is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Mosaic constant for GPU file prefix
Swapping out manual coded prefix file for a constant on the Mosaic side.
Confirmed that this works with logging