Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NCCL arg since torch deprecated old one #3000

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Update NCCL arg since torch deprecated old one #3000

merged 1 commit into from
Feb 13, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Update NCCL arg since torch deprecated old one

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner February 13, 2024 02:03
dakinggg
dakinggg reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version was the new arg introduced in?

@mvpatel2000 mvpatel2000 requested review from dakinggg and a team February 13, 2024 02:07
@mvpatel2000
Copy link
Contributor Author

What version was the new arg introduced in?

I verified it exists in torch 2.0

@mvpatel2000 mvpatel2000 merged commit b1e7db4 into mosaicml:dev Feb 13, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/patch-arg branch February 13, 2024 02:42
mvpatel2000 added a commit that referenced this pull request Feb 13, 2024
@mvpatel2000
Revert "fix (#3000)"
1be98ad 
This reverts commit b1e7db4.
@mvpatel2000 mvpatel2000 mentioned this pull request Feb 13, 2024
Merged
mvpatel2000 added a commit that referenced this pull request Feb 13, 2024
@mvpatel2000
Revert "fix (#3000)" (#3004)
0d041ac 
This reverts commit b1e7db4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg