Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][UC] Add back the full object path #2988

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

nancyhung
Copy link
Contributor

What does this PR do?

In previous change, #2982 I dropped using the full object path self._get_object_path(object_name). This PR adds it back.

Testing

Works when modified the code in long-living pod in prod.

>>> llmfoundry.data.finetuning.dataloader._download_remote_hf_dataset('dbfs:/Volumes/finetuning/ift/train_vol', 'train')
'/usr/lib/python3/dist-packages/llmfoundry/.downloaded_finetuning/train'

confirmed file is downloaded in the directory

# head data/train-00000-of-00001.jsonl
{"prompt": "<|im_start|>system\nA conversation between a user and an LLM-based AI assistant.
...

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@nancyhung nancyhung enabled auto-merge (squash) February 9, 2024 06:11
@nancyhung nancyhung merged commit 2fd6dd6 into dev Feb 9, 2024
14 checks passed
@nancyhung nancyhung deleted the nancy/another-uc-bug branch February 9, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants