Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lp layernorm weight #2954

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix lp layernorm weight #2954

merged 2 commits into from
Feb 1, 2024

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

Fixes LP layernorm weight attribute.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested a review from a team as a code owner February 1, 2024 03:50
@b-chu b-chu changed the title lp layernorm weight fix Fix lp layernorm weight Feb 1, 2024
@b-chu @mvpatel2000
Update composer/algorithms/low_precision_layernorm/low_precision_laye…
cd94d0d 
…rnorm.py

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
@b-chu b-chu enabled auto-merge (squash) February 1, 2024 04:19
@b-chu b-chu merged commit 3c14906 into dev Feb 1, 2024
14 checks passed
@b-chu b-chu deleted the lp_layernorm_weight_fix branch February 1, 2024 04:36
b-chu added a commit that referenced this pull request Feb 1, 2024
@snarayan21 @b-chu @mvpatel2000
Fix lp layernorm weight (#2954)
7b3e651 
* lp layernorm weight fix

* Update composer/algorithms/low_precision_layernorm/low_precision_layernorm.py

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>

---------

Co-authored-by: Brian <23239305+b-chu@users.noreply.github.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
j316chuck pushed a commit that referenced this pull request Feb 2, 2024
@snarayan21 @b-chu
@mvpatel2000 @j316chuck
Fix lp layernorm weight (#2954)
78ea55f 
* lp layernorm weight fix

* Update composer/algorithms/low_precision_layernorm/low_precision_layernorm.py

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>

---------

Co-authored-by: Brian <23239305+b-chu@users.noreply.github.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
j316chuck pushed a commit that referenced this pull request Feb 2, 2024
@snarayan21 @b-chu
@mvpatel2000 @j316chuck
Fix lp layernorm weight (#2954)
b8e08f4 
* lp layernorm weight fix

* Update composer/algorithms/low_precision_layernorm/low_precision_layernorm.py

Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>

---------

Co-authored-by: Brian <23239305+b-chu@users.noreply.github.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snarayan21 @mvpatel2000 @b-chu