-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce function versioning #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
April 28, 2023 20:39
fe32b0a
to
1953999
Compare
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
May 8, 2023 12:07
7e91139
to
79e29ab
Compare
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
May 8, 2023 12:23
c67a05d
to
eff36b3
Compare
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
2 times, most recently
from
May 8, 2023 15:48
921be6b
to
51932fb
Compare
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
May 8, 2023 15:50
51932fb
to
06f33bd
Compare
thomasgouveia
changed the title
Allow multiple builds for a function
Introduce function versioning
May 8, 2023
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
May 8, 2023 15:54
431a3dd
to
1b144a4
Compare
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
3 times, most recently
from
May 11, 2023 17:33
1b144a4
to
7543c03
Compare
Signed-off-by: thomasgouveia <gouveia.thomas@outlook.fr>
Signed-off-by: thomasgouveia <gouveia.thomas@outlook.fr>
Signed-off-by: thomasgouveia <gouveia.thomas@outlook.fr>
Signed-off-by: thomasgouveia <gouveia.thomas@outlook.fr>
- Updated function structs to handle version - Updated states engines to manage keys with versions - Update `rik` orchestrator engine so workloads will have the following name pattern: `name:version` Signed-off-by: thomasgouveia <gouveia.thomas@outlook.fr>
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
May 11, 2023 17:34
7543c03
to
3fb09d2
Compare
Signed-off-by: thomasgouveia <gouveia.thomas@outlook.fr>
thomasgouveia
force-pushed
the
f-allow-rebuilding-function
branch
from
May 11, 2023 17:36
3fb09d2
to
d3ddf2d
Compare
mflagey
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following improvements and fixes :
DeleteFunctionInstance
function signatureSee #10 for more details.
Closes #10
How to test ?
Run a classic Morty instance on this branch. Please note that I wasn't able to test the PR with a previous state (e.g: updating an existing morty instance). If you can test this, its great !
Prerequisites
Steps
Create a new function with the CLI :
Build it :
Invoke it (by default, if you don't specify a version with the
--version
flag, the latest version will be invoked):Now, update the code of your function to return another message, for example "Hello from my new version". Bump the version in the
morty.yaml
file tov0.1.1
, and re-build your function :Once done, invoke the new version :
Ensure that you can also invoke the previous version :