Filtered record being deleted on update

[kidzen]

Type 🐛

class Company () {
    ...
    public function getBranches()
    {
        return $this->hasMany(\common\models\Branch::className(), ['company_id' => 'id'])
        ->andWhere(['type' =< 10 ]);
    }
}

on update company record, those record with type 11 and above got deleted...

Suggestion :
add $ignoreClause parameter for saveAll() as additional

    public function saveAll($skippedRelations = [],$ignoreClause = [])
    {
        ....
        $query = ['and', $notDeletedFK, ['not in', $relPKAttr[0], $notDeletedPK]];
        array_push($query, $ignoreClause);           ....
        ...
        if (!empty($notDeletedPK)) {
            try {
                if ($isSoftDelete) {
                    $relModel->updateAll($this->_rt_softdelete, $query);
                } else {
                    $relModel->deleteAll($query);
                }
            } catch (IntegrityException $exc) {
                $this->addError($name, "Data can't be deleted because it's still used by another data.");
                $error = true;
            }
        }
        ....
    }

or adding list of effectiveIds only

[kidzen]

closely related #48

[deadmantfa]

Hi I have been having the same issue. The problem is that it checks for ActiveQuery link parameter which return the relationship link but does not send the additional information such as on conditions and other conditions added to the relationship.
Check line 113 and code from line 172-181

[deadmantfa]

The $AQ variable has the conditions etc we can use that to add the delete query with more conditions based on the relationship condition

[kidzen]

@deadmantfa so currently how did u handle this...

trait RelationTrait
{
    ....
    public function saveAll($skippedRelations = [],$ignoreList = [])
    {
    ....
                                            if($relModel->classname() === 'common\models\Branch'){
                                                $notEffective = ['not in', 'id', $ignoreList['common\models\Branch']];
                                                $query = ['and', ['company_id'=>12], ['not in', 'id', $notDeletedPK]];
                                                var_dump($relModel);
                                                array_push($query, $ignoreList);
                                                // var_dump($query);
                                            }
     }
}

[deadmantfa]

@kidzen Thanks for this I am trying a much better approach as i want to follow the code that's been there I am going to make a pull request on it soon.

[ragua]

This is a really major issue deleting records with a parent update, this must be solved urgently or this soft won't be used anymore.

[strtob]

Hi, is there any update? The software is really helpful and a great idea! Do anyone know a equal alterantive?

[synatree]

The linked issue has a commit that solves the problem.