refactor braft to support hostname as PeerId's endpoint #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xiaolin310
commented
Nov 17, 2023
xiaolin310
commented
- define a struct named HostNameAddr, as an attribute of PeerId
- wrap a function to build naming_service_url, which is used for brpc channel init
- modify logic about channel init with naming service
xiaolin310
force-pushed
the
refactor_hostname_addr
branch
from
66efd3b
to
0db90ba
Compare
* define a struct named HostNameAddr, as an attribute of PeerId * wrap a function to build naming_service_url, which is used for brpc channel init * modify logic about channel init with naming service
xiaolin310
force-pushed
the
refactor_hostname_addr
branch
from
0db90ba
to
7d5a607
Compare
xiaolin310
added a commit
that referenced
this pull request
Nov 30, 2023
* define a struct named HostNameAddr, as an attribute of PeerId * wrap a function to build naming_service_url, which is used for brpc channel init * modify logic about channel init with naming service * minor fix about hostnameAddr port_ type
xiaolin310
added a commit
that referenced
this pull request
Nov 30, 2023
* define a struct named HostNameAddr, as an attribute of PeerId * wrap a function to build naming_service_url, which is used for brpc channel init * modify logic about channel init with naming service * minor fix about hostnameAddr port_ type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.