Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R-Tree overload of beginRecording #129

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Add R-Tree overload of beginRecording #129

merged 3 commits into from
Jun 5, 2024

Conversation

mattleibow
Copy link

@mattleibow mattleibow commented Jun 4, 2024

Description of Change

Add the R-Tree overload of SkPicture::beginRecording.

Only the construction and destruction of the sole implementation of SkBBHFactory (the SkRTreeFactory class) is exposed. This is really an opaque type in skia and clients would create their own implementations if they wanted. However, this PR does not provide the API to do this since it is fairly complicated and not many use cases. It can be added later.

SkiaSharp Issue

Related to mono/SkiaSharp#2372

API Changes

sk_canvas_t* sk_picture_recorder_begin_recording_with_bbox_hierarchy(sk_picture_recorder_t*, const sk_rect_t*, sk_bbh_factory_t*);

sk_rtree_factory_t* sk_rtree_factory_new(void);
void sk_rtree_factory_delete(sk_rtree_factory_t*);

Behavioral Changes

None.

Required SkiaSharp PR

Requires mono/SkiaSharp#2889

PR Checklist

  • Rebased on top of skiasharp at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow changed the title Dev/rtree Add R-Tree overload to beginRecording Jun 4, 2024
@mattleibow mattleibow changed the title Add R-Tree overload to beginRecording Add R-Tree overload of beginRecording Jun 4, 2024
@mattleibow mattleibow merged commit e9d4ecc into skiasharp Jun 5, 2024
1 check passed
@mattleibow mattleibow deleted the dev/rtree branch June 5, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant