[2018-08] [debugger] Deadlock while debugging a process #14392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvoke and then when it's calling the invoke there is another call to process_suspend in the same thread.
|
@marek-safar can we land this in |
|
Is there a pkg i can download to test with on mac? |
|
@monojenkins build pkg |
|
@monojenkins build failed |
|
@alanmcgovern , the package is ready!! :) |
|
For the first time in... i have no idea how long... i was able to have multiple debug sessions and not see the infamous "The runtime has deadlocked" dialog box in VSMac. This is amazing. /cc @Therzok : I belive you see these deadlocks on a daily basis too, so please check out this build. It's literally made it possible to debug again! |
|
Yes, it is a world of difference! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deadlock happens when during a process_suspend there is a pending invoke and then when it's calling the invoke there is another call to process_suspend in the same thread.
Backport of #14368.
/cc @thaystg