Don't dispose of GpMetafile if a GpGraphics is using it #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Oct 2, 2020
Fixes dotnet#37838 Verified using libgdiplus built with mono/libgdiplus#671
|
Looks like on Win32 GDI+, you can dispose of the metadata or the graphics instances in either order. Instead of asserting, I'm working on extending the lifetime of the metadata object until the graphics instance is disposed if the metadata is disposed first. |
The Windows GDI+ allows the metafile instance to be disposed before the graphics instance. To support that, keep track in the GpGraphics of whether it is responsible for freeing the GpMetafile. If the graphics instance is deleted first, own_metafile is FALSE and nothing happens. If the metafile instance is disposed first, set own_metafile to TRUE and don't dispose of the metafile. It will be disposed when the graphics instance is deleted. --- Also on Windows GDI+ creating more than one graphics instance for a metafile instance throws an OutOfMemoryException, so do the same in GdipGetImageGraphicsContext
lambdageek
force-pushed
the
track-metafile-dispose
branch
from
92127ac
to
1af55cd
Compare
lambdageek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow GpGraphics to take ownership of GpMetafile on dispose
The Windows GDI+ allows the metafile instance to be disposed before the graphics instance.
To support that, keep track in the GpGraphics of whether it is responsible for freeing the GpMetafile.
If the graphics instance is deleted first, own_metafile is FALSE and nothing happens.
If the metafile instance is disposed first, set own_metafile to TRUE and don't dispose of the metafile. It will be disposed when the graphics instance is deleted.
Also on Windows GDI+ creating more than one graphics instance for a metafile
instance throws an OutOfMemoryException, so do the same in GdipGetImageGraphicsContext
This is related to dotnet/runtime#37838