-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-3998): metadata duplication in handshake #3615
Conversation
@@ -526,13 +529,14 @@ export interface ClientMetadata { | |||
version: string; | |||
}; | |||
platform: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong, according to the spec: https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#hello-command
this modifies a public interface but it's also technically a bug fix, so I think it's okay to remove
evergreen retry |
Co-authored-by: Warren James <warren.james.dev@gmail.com>
e64b5f8
to
5f2e229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
What is changing?
This PR prevents metadata duplication in the handshake. To do this, it removes custom transforms for the driverInfo and appName options and constructs the metadata once at the end of options parsing.
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript